[schema-coverage] feat: Add schema coverage demo for max-turn-cache-misses field#40753
Conversation
|
Hey One thing worth noting:
If you would like to address that gap, here is a ready-to-use prompt:
|
|
🧠 Matt Pocock Skills Reviewer has completed the skills-based review. ✅ |
|
✅ PR Code Quality Reviewer completed the code quality review. |
|
✅ Design Decision Gate 🏗️ completed the design decision gate check. No ADR enforcement needed: PR #40753 does not have the 'implementation' label and has 0 new lines of code in business logic directories (default threshold is 100). Both enforcement conditions are false. |
|
✅ Test Quality Sentinel completed test quality analysis. No test files were added or modified in this PR. The only change is schema-demos/schema-demo-max-turn-cache-misses.md (a markdown file). Test Quality Sentinel skipped. |
There was a problem hiding this comment.
Pull request overview
Adds a minimal schema demo workflow to exercise the max-turn-cache-misses frontmatter field, improving schema feature coverage for gh-aw workflows.
Changes:
- Added a new schema demo markdown workflow showcasing
max-turn-cache-misses: 5. - Included a minimal
nooptask body to keep the demo execution side-effect free.
Show a summary per file
| File | Description |
|---|---|
schema-demos/schema-demo-max-turn-cache-misses.md |
New schema demo workflow demonstrating the max-turn-cache-misses frontmatter key with a noop task. |
Copilot's findings
Tip
Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Files reviewed: 1/1 changed files
- Comments generated: 0
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
No blocking issues — APPROVE
Single new file schema-demos/schema-demo-max-turn-cache-misses.md follows the established schema-demo pattern exactly.
Frontmatter (engine: codex, timeout-minutes: 5, permissions: contents: read, max-turn-cache-misses: 5) is consistent with peer files. Task body noop format matches all other schema demo files. No logic errors, security issues, or correctness concerns in the changed lines.
🔎 Code quality review by PR Code Quality Reviewer · 36.5 AIC · ⌖ 7.34 AIC · ⊞ 5.1K
There was a problem hiding this comment.
Skills-Based Review 🧠
Applied /grill-with-docs — approving with a minor documentation suggestion.
📋 Key Themes & Highlights
Key Themes
- Missing field metadata in description: The
What ... Doessection describes the field purpose but omits the internal config mapping, env var override, and default value — context that peer demos include and that makes the file useful beyond just coverage.
Positive Highlights
- ✅ Consistent structure with all existing schema demos (
schema-demo-max-runs.md,schema-demo-max-tool-denials.md, etc.) - ✅ Correct engine choice (
codex) for an AWF-proxy-level field - ✅ Valid frontmatter, appropriate
timeout-minutes, andpermissions: contents: read - ✅ Clean, minimal implementation that achieves its schema coverage goal
🧠 Reviewed using Matt Pocock's skills by Matt Pocock Skills Reviewer · 52.5 AIC · ⌖ 7.45 AIC · ⊞ 6.5K
| ## What `max-turn-cache-misses` Does | ||
|
|
||
| Maximum number of consecutive AWF cache misses allowed before the API proxy | ||
| blocks further requests. |
There was a problem hiding this comment.
[/grill-with-docs] The What ... Does description omits the internal field mapping and default value that make similar demos more useful as reference documentation.
💡 Suggestion
Other demos include the internal mapping in their description. For example, schema-demo-max-runs.md reads:
Deprecated legacy alias for AWF invocation cap (
apiProxy.maxRuns). Usemax-turnsinstead.
The PR body template attempted to include this metadata (Maps to <field>. Precedence: frontmatter value → <env_var> env override → built-in default <default>.) but the placeholders were left empty, and that information did not make it into the committed file body either.
Consider enriching the description — something like:
Maximum number of consecutive AWF cache misses allowed before the API proxy
blocks further requests. Maps to `apiProxy.maxTurnCacheMisses`. Precedence:
frontmatter value → `AWF_MAX_TURN_CACHE_MISSES` env override → built-in default `10`.(Adjust the field path, env var, and default to match the actual schema values.)
This makes the demo genuinely educational rather than just a coverage stub.
Summary
Adds a single new demo file that exercises the
max-turn-cache-missesfrontmatter field, closing the last gap in schema feature coverage for theschema-demos/collection.What changed and why
schema-demos/schema-demo-max-turn-cache-misses.mdmax-turn-cache-missesfrontmatter field; brings schema demo coverage to 100%.Impact assessment
Field reference
max-turn-cache-misses— Maximum number of consecutive AWF cache misses allowed before the API proxy blocks further requests. The demo sets this to5.Testing / Verification
schema-demos/schema-demo-max-turn-cache-misses.mdis valid against the project workflow schema.max-turn-cache-missesdemo already exists.